Fix std::net::SocketAddr to libc::sockaddr conversion. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstyura
changed the title
|
@dlon could you please review this PR, thanks a lot in advance! |
mstyura
force-pushed
the
fix-sockaddr-to-c-conversion
branch
from
ec2c0af to
13abe36
Compare
|
@faern could you please take a look at this PR and merge if you are ok with changes? Thanks a lot in advance, Yury. |
|
Hi. Sorry for the slow reply. It's still vacation period in Sweden and many developers are off. We'll get back to you once we have the manpower to handle third party PRs :) Thanks for contributing a fix! |
|
Ok, no problem at all, have a great vacation! |
faern
reviewed
Aug 20, 2024
mstyura
force-pushed
the
fix-sockaddr-to-c-conversion
branch
from
13abe36 to
5f28321
Compare
faern
approved these changes
Aug 21, 2024
faern
added a commit
that referenced
this pull request
Aug 21, 2024
Fix std::net::SocketAddr to libc::sockaddr conversion.
|
This fix has now been published, as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make
SCNetworkReachabilityCreateWithAddressPairwork with any valid pair of addresses, not only0.0.0.0.The fixed implementation is mostly taken from
socket2This change is