[DataGrid] Fix scrollbars overlapping cells on mount #16639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
bug 🐛
|
Deploy preview: https://deploy-preview-16639--material-ui-x.netlify.app/ |
KenanYusuf
added
needs cherry-pick
cherniavskii
added
bug 🐛
cherniavskii
approved these changes
Feb 19, 2025
| @@ -745,7 +745,9 @@ describe('<DataGrid /> - Rows', () => { | |||
| width={100} | |||
| />, | |||
| ); | |||
| expect($$(`.${gridClasses.cell}:not(.${gridClasses.cellEmpty})`)).to.have.length(2); | |||
| await waitFor(() => { | |||
There was a problem hiding this comment.
Is waitFor necessary here? Was the test failing after applying the fix?
There was a problem hiding this comment.
Was the test failing after applying the fix?
I didn't quite get to the root of the problem, but noticed that on first render the rowHasAutoHeight function here returns false https://github.com/mui/mui-x/blob/master/packages/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx#L882 but then corrects itself on second render.
I don't know if the waitFor is masking an issue, but no other tests failed 🤷
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See reproduction steps in #16628 to try the fix locally.
Before
After
Fixes #16628