[DataGrid] Extract getRowId API method as a selector

[MBilalShafi]

Fixes #16103

• Before: https://codesandbox.io/p/sandbox/vigorous-napier-xsrh7q
• After:

Fixes #16413

• Before: https://codesandbox.io/p/sandbox/frosty-resonance-2w634q?file=%2Fsrc%2FDemo.tsx%3A14%2C12
• After:

Better fix for #14691

Reuses the props state logic initially committed in #12343

Changelog

• Deprecate getRowId API method. gridRowIdSelector should be used instead.
• Deprecate getRowNode API method. gridRowNodeSelector should be used instead.

[MBilalShafi]

Any thoughts about deprecating it in favor of the added utility?
Deprecated in favor of the new selector gridRowIdSelector
We could remove all internal instances later.

[mui-bot]

Deploy preview: https://deploy-preview-16487--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fd2c51e

[cherniavskii]

Are we sure about deprecating these? 🤔
Discovering and calling a method is much easier than discovering the selector and importing it.

[MBilalShafi]

Discovering and calling a method is much easier than discovering the selector and importing it.

It's a good point.

Here are the arguments I have in mind in favor of the deprecation:

1. Both getRowId and getRowNode are meant to be used internally more than 90% of the times and having API methods for them kind-of feels redundant.
2. Less API surface (especially for the cases where there's an easy workaround) is always better for maintainability etc.
3. Using selectors is not something that we rarely use now, after the reactivity improvements, it's been used very frequently at multiple places, I'd personally try to use documentation to elaborate the use of those selectors to solve the discoverability, if we feel a knowledge gap.

Since we are deprecating them and not removing them until next major, if there's a discoverability pain reported by a noticeable number of users we can always bring them back. (We could avoid deprecating them in v7) Wdyt?

[github-actions]

Cherry-pick PRs will be created targeting branches: v7.x