-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump monorepo and core packages #11900
Conversation
"@mui/utils": "^5.15.5", | ||
"@mui/icons-material": "^5.15.7", | ||
"@mui/material": "^5.15.7", | ||
"@mui/monorepo": "https://github.com/mui/material-ui#e1231ee8c18ff93b5129cfb5ff7c7e30ad8743e3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to have to switch to such approach for pnpm
anyways.
Why not now? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasTy You mean that with pnpm
we will have to set the commit hash to bump the monorepo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specifically bump, but stop pnpm dedupe
from failing. 😉
When you run pnpm dedupe
with #master
, it finds that there is a newer commit and tries applying it... 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mui-toolpad has also gone the same route: https://github.com/mui/mui-toolpad/blob/1de30d83479572246a4f6f5984636fc24678cc2e/package.json#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do the same on the next
branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there is any rush for it.
Hopefully pnpm
migration won't take too long. 🙈
Deploy preview: https://deploy-preview-11900--material-ui-x.netlify.app/ |
master
branch for easier controlcore
package versions