Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump monorepo and core packages #11900

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Bump monorepo and core packages #11900

merged 1 commit into from
Feb 1, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 1, 2024

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Feb 1, 2024
@LukasTy LukasTy self-assigned this Feb 1, 2024
"@mui/utils": "^5.15.5",
"@mui/icons-material": "^5.15.7",
"@mui/material": "^5.15.7",
"@mui/monorepo": "https://github.com/mui/material-ui#e1231ee8c18ff93b5129cfb5ff7c7e30ad8743e3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to have to switch to such approach for pnpm anyways.
Why not now? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasTy You mean that with pnpm we will have to set the commit hash to bump the monorepo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically bump, but stop pnpm dedupe from failing. 😉
When you run pnpm dedupe with #master, it finds that there is a newer commit and tries applying it... 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same on the next branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is any rush for it.
Hopefully pnpm migration won't take too long. 🙈

@mui-bot
Copy link

mui-bot commented Feb 1, 2024

Deploy preview: https://deploy-preview-11900--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4ad1ae2

@LukasTy LukasTy requested a review from a team February 1, 2024 12:48
@LukasTy LukasTy enabled auto-merge (squash) February 1, 2024 12:50
@LukasTy LukasTy merged commit 10a3e4e into mui:master Feb 1, 2024
18 checks passed
@LukasTy LukasTy deleted the bump-monorepo branch February 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants