Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IconButton] Better follow the spec #9967

Merged
merged 1 commit into from
Jan 20, 2018
Merged

[IconButton] Better follow the spec #9967

merged 1 commit into from
Jan 20, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 20, 2018 •
edited
Loading

Before
capture d ecran 2018-01-20 a 12 23 36

After
capture d ecran 2018-01-20 a 12 22 48

However, it seems that we don't follow the specification closely enough. The focus indicator ring should take the color of the icon into account. Right now, we don't.

@oliviertassinari oliviertassinari added component: icon button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Jan 20, 2018
@oliviertassinari oliviertassinari merged commit 0724dad into mui:v1-beta Jan 20, 2018
@oliviertassinari oliviertassinari deleted the icon-button-spec branch January 20, 2018 11:59
@mbrookes mbrookes mentioned this pull request Jan 20, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: icon button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliviertassinari