-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Upgrade react-tap-event-plugin and react peer dependency #6057
Conversation
Checking out error circleci now. Did not have an issue locally. |
… version of node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me.
It's going to be a breaking change.
Could you add a ##### Breaking Changes
section on the CHANGELOG.md
so we don't forget it? Thanks.
CHANGELOG.md
Outdated
@@ -1,5 +1,11 @@ | |||
## HEAD | |||
|
|||
## 0.16.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.17.0
or just keep it under the HEAD
section.
react-tap-event-plugin@^2.0.0
for react@^15.4.0
react-tap-event-plugin@^2.0.0
for react@^15.4.0
react-tap-event-plugin@^2.0.0
for react@^15.4.0
@rosskevin Thanks |
react-tap-event-plugin@^2.0.0
for react@^15.4.0
Fixes #5646
React
15.4
requires the minimum version forreact-tap-event-plugin
to be2.0.1
.The restriction was a bit lenient previously (which would fail with react
15.4
), so hopefully raising the restriction exposes any other conflicts that were previously hidden. The react version will be raised to15.4
as well.