Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Improve Grid2 upgrade experience #45304

Merged
merged 11 commits into from
Feb 20, 2025

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Feb 14, 2025

This is step 0 of #43437:

@DiegoAndai DiegoAndai added the component: Grid The React component. label Feb 14, 2025
@DiegoAndai DiegoAndai self-assigned this Feb 14, 2025
@DiegoAndai DiegoAndai changed the title [Grid] Improve Grid v2 upgrade guide [Grid] Improve Grid v2 upgrade experience Feb 14, 2025
@mui-bot
Copy link

mui-bot commented Feb 14, 2025

@DiegoAndai DiegoAndai added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Feb 14, 2025
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for @mapache-salvaje comments.

@siriwatknp siriwatknp mentioned this pull request Feb 19, 2025
10 tasks
@DiegoAndai DiegoAndai force-pushed the improve-grid2-migration branch 3 times, most recently from bf0f54b to a3e6172 Compare February 19, 2025 22:16
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Diego Andai <[email protected]>
@DiegoAndai DiegoAndai force-pushed the improve-grid2-migration branch from a3e6172 to 0e8f23a Compare February 19, 2025 22:25
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving after these last few edits!

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Diego Andai <[email protected]>
@DiegoAndai DiegoAndai changed the title [Grid] Improve Grid v2 upgrade experience [Grid] Improve Grid2 upgrade experience Feb 20, 2025
@DiegoAndai DiegoAndai merged commit 428a019 into mui:master Feb 20, 2025
22 checks passed
@DiegoAndai DiegoAndai deleted the improve-grid2-migration branch February 20, 2025 11:32
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. needs cherry-pick The PR should be cherry-picked to master after merge v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants