Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v6.4.4 #45286

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[release] v6.4.4 #45286

merged 3 commits into from
Feb 11, 2025

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova added the release We are shipping :D label Feb 11, 2025
@mui-bot
Copy link

mui-bot commented Feb 11, 2025

Netlify deploy preview

https://deploy-preview-45286--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7991598

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aarón García Hervás <[email protected]>
Signed-off-by: Marija Najdova <[email protected]>
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing packages here: utils, system, material-nextjs, material-pigment-css, the styled engine ones, and private theming

Also missing this from the CHANGELOG: 8efd596

@mnajdova
Copy link
Member Author

mnajdova commented Feb 11, 2025

We're missing packages here: utils, system, material-nextjs, material-pigment-css, the styled engine ones, and private theming

Isn't the changelog generated based on what packages have changes? Is there something else needed to be done?

Also missing this from the CHANGELOG: 8efd596

Edit: The release changelog script omits the commits for the [website], the logic was added in #44069

@mnajdova mnajdova requested a review from DiegoAndai February 11, 2025 12:59
@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 11, 2025

Isn't the changelog generated based on what packages have changes? Is there something else needed to be done?

Yeah but all the packages that follow Material versioning (6.4.3 -> 6.4.4) should be bumped regardless of changes, that's what we've always done: https://github.com/mui/material-ui/blob/HEAD/scripts/README.md#release:~:text=Keep%20the%20package%20versions%20of%20stable%20public%20packages%20the%20same%20as%20the%20root%20package.json%20version.

@mnajdova
Copy link
Member Author

Yeah but all the packages that follow Material versioning (6.4.3 -> 6.4.4) should be bumped regardless of changes, that's what we've always done:

I don't think this is correct. We said if a package is not updated in one release, next time it would be bumped to match the version of the root's package.json. This is how lerna works, otherwise we will need to always manually update all packages.

@DiegoAndai
Copy link
Member

We said if a package is not updated in one release, next time it would be bumped to match the version of the root's package.json

Ok, that's fine by me. I'll update the release instructions 👍🏼

@mnajdova mnajdova merged commit c66361a into mui:v6.x Feb 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants