-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release] v6.4.4 #45286
[release] v6.4.4 #45286
Conversation
mnajdova
commented
Feb 11, 2025
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-45286--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Co-authored-by: Aarón García Hervás <[email protected]> Signed-off-by: Marija Najdova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing packages here: utils, system, material-nextjs, material-pigment-css, the styled engine ones, and private theming
Also missing this from the CHANGELOG: 8efd596
Isn't the changelog generated based on what packages have changes? Is there something else needed to be done?
Edit: The release changelog script omits the commits for the [website], the logic was added in #44069 |
Yeah but all the packages that follow Material versioning (6.4.3 -> 6.4.4) should be bumped regardless of changes, that's what we've always done: https://github.com/mui/material-ui/blob/HEAD/scripts/README.md#release:~:text=Keep%20the%20package%20versions%20of%20stable%20public%20packages%20the%20same%20as%20the%20root%20package.json%20version. |
I don't think this is correct. We said if a package is not updated in one release, next time it would be bumped to match the version of the root's package.json. This is how lerna works, otherwise we will need to always manually update all packages. |
Ok, that's fine by me. I'll update the release instructions 👍🏼 |