Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab] Remove components which were moved from lab to material #45232

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DiegoAndai
Copy link
Member

Closes #43025.

  • Even though the lab is an experimental package, I added a section about this change in the v7 upgrade guide just in case
  • I also included a codemod for the change

@DiegoAndai DiegoAndai added the package: lab Specific to @mui/lab label Feb 6, 2025
@DiegoAndai DiegoAndai self-assigned this Feb 6, 2025
@DiegoAndai DiegoAndai force-pushed the remove-lab-deprecated-components branch from 21c8867 to 95c948d Compare February 6, 2025 18:36
@mui-bot
Copy link

mui-bot commented Feb 6, 2025

Netlify deploy preview

@material-ui/lab: parsed: -45.99% 😍, gzip: -43.76% 😍
SpeedDialAction: parsed: -0.20% 😍, gzip: -0.28% 😍
PaginationItem: parsed: -0.28% 😍, gzip: -0.36% 😍
Pagination: parsed: -0.27% 😍, gzip: -0.34% 😍
ToggleButtonGroup: parsed: -0.38% 😍, gzip: -0.40% 😍
SpeedDial: parsed: -0.26% 😍, gzip: -0.34% 😍
ToggleButton: parsed: -0.30% 😍, gzip: -0.35% 😍
Alert: parsed: -0.24% 😍, gzip: -0.35% 😍
Rating: parsed: -0.31% 😍, gzip: -0.37% 😍
Autocomplete: parsed: -0.15% 😍, gzip: -0.21% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d0da143

Comment on lines +64 to +66
:::warning
The codemod doesn't cover type imports associated with the components.
:::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth our time to add them, there are a lot of them, and I think users are rarely using them. We can add them in the future if enough people ask.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The default component type, i.e., the Alert type for the Alert component, is covered as it's "the same" import as the component)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: lab Specific to @mui/lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lab] Remove deprecated lab components
2 participants