[docs] A quick first step to update docs for Tailwind v4 #45147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ All credits go to the Tailwind Labs team for designing this component, found on | |||
| ## Setting up the project | |||
|
|
|||
| We'll use [`create-react-app` with TypeScript](https://create-react-app.dev/docs/adding-typescript/#installation) for this guide. | |||
| After you have created the project, follow the instructions given on the [Tailwind CSS installation page](https://tailwindcss.com/docs/guides/create-react-app) in order to configure `tailwind`. | |||
| After you have created the project, follow the instructions given on the [Tailwind CSS installation page](https://tailwindcss.com/docs/installation/framework-guides) in order to configure `tailwind`. | |||
There was a problem hiding this comment.
Granted this is a very small change, but is it worthwhile to continue updating the MUI Base docs at all? This doc in particular needs more thorough revisions since CRA is dead—and it's not included in the Tailwind framework guides—but I don't think it would be worth the effort.
There was a problem hiding this comment.
It's a search and replace. It was flagged by the SEO crawler. I think it's simpler to fix it, so it doesn't create noise in the report. The value is to be able to better fix Material UI docs.
oliviertassinari
added
v6.x
needs cherry-pick
|
Cherry-pick PRs will be created targeting branches: v6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of docs to update for Tailwind v4 #45220. Doing a quick first update to help.