Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix migration feedback #35232

Merged
merged 3 commits into from
Nov 24, 2022
Merged

[docs] Fix migration feedback #35232

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
737e5f8
[docs] Fix migration feedback
alexfauquette Nov 22, 2022
e771311
feedbacks
alexfauquette Nov 22, 2022
c3c48ac
off topic: this feels more like an info
oliviertassinari Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/data/material/migration/migration-v4/migration-v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,20 @@ We will not change the minimum supported version in a major version of Material
However, we generally recommend not to use a TypeScript version older than the lowest supported version of DefinitelyTyped.
:::

If you are using a react verison bellow 17.0.0, update your packages to at least v14.11.2 for Material UI and v17.0.0 for react.

With npm:

```sh
npm update @material-ui/core@^4.11.2 react@^17.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't run

Screenshot 2023-02-13 at 20 43 15

I think that it should be

Suggested change
npm update @material-ui/core@^4.11.2 react@^17.0.0
npm install @material-ui/core@^4.11.2 react@^17.0.0

```

With yarn:

```sh
yarn upgrade @material-ui/core@^4.11.2 react@^17.0.0
```

If your project includes these packages, you'll need to update them to the `latest` version:

- `react-scripts`
Expand Down