Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.12.3 #27465

Merged
merged 5 commits into from
Jul 30, 2021
Merged

v4.12.3 #27465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb4fb98
v4.12.3
eps1lon Jul 27, 2021
172661e
Update CHANGELOG.md
eps1lon Jul 27, 2021
83d4476
Update CHANGELOG.md
eps1lon Jul 27, 2021
6a573ed
Merge branch 'master' into release/4.12.3
eps1lon Jul 30, 2021
bb19dfa
Add marija ass release contributor
eps1lon Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
### [Versions](https://material-ui.com/versions/)

## 4.12.3

<!-- generated comparing v4.12.2..master -->

_Jul 27, 2021_

### `@material-ui/[email protected]`

- <!-- 2 --> [AccordionSummary] Fix false-positive propType warning with `disableGeneration` (#27385) @eps1lon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is the Accordion?

Suggested change
- <!-- 2 --> [AccordionSummary] Fix false-positive propType warning with `disableGeneration` (#27385) @eps1lon
- <!-- 2 --> [Accordion] Fix AccordionSummary false-positive propType warning with `disableGeneration` (#27385) @eps1lon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

- <!-- 7 --> [ImageList] Fix deprecation warnings (#27502) @mnajdova
- <!-- 6 --> [TablePagination] Re-introduce deprecated `onChangePage` to `ActionsComponent` (#27407) @eps1lon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is the Table?

Suggested change
- <!-- 6 --> [TablePagination] Re-introduce deprecated `onChangePage` to `ActionsComponent` (#27407) @eps1lon
- <!-- 6 --> [Table] Re-introduce deprecated TablePagination `onChangePage` to `ActionsComponent` (#27407) @eps1lon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed TablePagination, not Table:
https://github.com/mui-org/material-ui/pull/27407/files

Copy link
Member

@oliviertassinari oliviertassinari Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried to document the standard used so far in https://www.notion.so/material-ui/GitHub-issues-PRs-c1d7072e0c2545b0beb43b115f6030f6

A pull request most often has one primary label. It's defined with the "[XXX] Syntax". XXX must match with existing GitHub labels.

It's arbitrary, I think that what matters is to be consistent. "Table" matches an existing GitHub label.

If we want to change the standard, then it's a different discussion, why not.

I think that we should get it changed at the whole org level, not on an individual basis. It would help external developers read the changelog, the issues, the PRs, contribute.

Copy link
Member Author

@eps1lon eps1lon Jul 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't discuss it to begin with so I don't accept that standard. Your approach is not suitable for a changelog which is what we're discussing here.

You already agreed with my approach: The title should match the component. Though you mistook the PR to adress the Table component. However, it did adress the TablePagination component so that's the correct title.

I think that we should get it changed at the whole org level, not on an individual basis.

Agreed. There's no org-level at the moment though.

- <!-- 1 --> [TextareaAutosize] Updated deprecation warning to suggest minRows instead of rowsMin (#27398) @HumbertoL

### Docs

- <!-- 4 --> [docs] Fix 404 link to ImageList @oliviertassinari
- <!-- 3 --> [docs] Fix DataTable.tsx demo in v4 (#27196) @Siv-tspab

### Core

- <!-- 5 --> [core] Add release scripts (#27399) @eps1lon

All contributors of this release in alphabetical order: @eps1lon, @mnajdova, @HumbertoL, @oliviertassinari, @Siv-tspab

## 4.12.2

<!-- generated comparing v4.12.1..master -->
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "4.12.2",
"version": "4.12.3",
"private": true,
"scripts": {
"proptypes": "ts-node --skip-project ./scripts/generateProptypes.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/material-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@material-ui/core",
"version": "4.12.2",
"version": "4.12.3",
"private": false,
"author": "Material-UI Team",
"description": "React components that implement Google's Material Design.",
Expand Down