Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Migrate ButtonBase to react-testing-library #23011

Merged
merged 4 commits into from
Oct 14, 2020
Merged

[test] Migrate ButtonBase to react-testing-library #23011

merged 4 commits into from
Oct 14, 2020

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Oct 12, 2020 •
edited by oliviertassinari
Loading

#22911

@oliviertassinari oliviertassinari changed the title Migrate tests to use react-testing-library [test] Migrate ButtonBase to use react-testing-library Oct 12, 2020
@oliviertassinari oliviertassinari changed the title [test] Migrate ButtonBase to use react-testing-library [test] Migrate ButtonBase to react-testing-library Oct 12, 2020
@deiga
Remove mistaken 'only'
d154d8b 
Signed-off-by: Timo Sand <[email protected]>
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 12, 2020 •
edited
Loading

No bundle size changes comparing 6f59621...45a8c3e

Generated by 🚫 dangerJS against 45a8c3e

@deiga
Copy link
Contributor Author

deiga commented Oct 12, 2020

@oliviertassinari Apparently there are some TS issues with Sinon stub, which stem from how TS3.5 interprets types (DefinitelyTyped/DefinitelyTyped#36019). Should I ts-ignore those?

Additionally, there is an issue with TS when getting the 'style' object.I could replace that with 'chai-styles' if appropriate?

@deiga deiga force-pushed the migrate-buttonbase-tests branch from fad89da to 17627ea Compare October 13, 2020 13:21
@deiga deiga force-pushed the migrate-buttonbase-tests branch from 17627ea to 7481f1d Compare October 13, 2020 13:25
@deiga
Copy link
Contributor Author

deiga commented Oct 13, 2020

@oliviertassinari Yeah, that made more sense, changed it!

oliviertassinari
oliviertassinari reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the assertions of the two test cases? They look identical.

@oliviertassinari oliviertassinari force-pushed the migrate-buttonbase-tests branch from c7f464e to 45a8c3e Compare October 13, 2020 19:23
@oliviertassinari oliviertassinari merged commit 888614b into mui:next Oct 14, 2020
@oliviertassinari
Copy link
Member

@deiga Thanks!

@deiga deiga deleted the migrate-buttonbase-tests branch October 15, 2020 11:32
@eps1lon eps1lon mentioned this pull request Jun 25, 2021
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: ButtonBase The React component. test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deiga @mui-pr-bot @oliviertassinari