Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add Snackbars TypeScript Demos #15087

Merged
merged 5 commits into from
Mar 30, 2019
Merged

[docs] Add Snackbars TypeScript Demos #15087

merged 5 commits into from
Mar 30, 2019

Conversation

sperry94
Copy link
Contributor

Added TS demos for Snackbars components as a part of #14897

Also, rewrote the ConsecutiveSnackbars demo to use hooks to get around a proptypes typescript error with styles.

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 28, 2019 •
edited
Loading

No bundle size changes comparing be889d9...1b594f9

Generated by 🚫 dangerJS against 1b594f9

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Mar 28, 2019
eps1lon
eps1lon previously requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, rewrote the ConsecutiveSnackbars demo to use hooks to get around a proptypes typescript error with styles.

Could you do this in a separate PR? You can look at the other demos how to get around propTypes errors.

@sperry94
Copy link
Contributor Author

Also, rewrote the ConsecutiveSnackbars demo to use hooks to get around a proptypes typescript error with styles.

Could you do this in a separate PR? You can look at the other demos how to get around propTypes errors.

@eps1lon @oliviertassinari I was able to find another demo with a pattern I could follow! I've updated ConsecutiveSnackbar to just convert to TS!

@oliviertassinari oliviertassinari merged commit 7c03f10 into mui:next Mar 30, 2019
@oliviertassinari
Copy link
Member

@sperry94 Thanks

This was referenced Mar 31, 2019
Closed
Merged
eps1lon added a commit that referenced this pull request Mar 31, 2019
@eps1lon
[docs] Polish Snackbar demos (#15129)
f9e8cb2 
Removes some unnecessary JS diffs created in #15087.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sperry94 @mui-pr-bot @oliviertassinari @eps1lon