[docs] Demo codesandbox deps #10158
[docs] Demo codesandbox deps #10158
Conversation
caub
force-pushed
the
demo-dyn-deps
branch
2 times, most recently
from
a6eafee to
a56aa47
Compare
oliviertassinari
changed the title
| @@ -55,6 +55,10 @@ module.exports = { | |||
| 'import/unambiguous': 'off', // scripts | |||
| 'import/namespace': ['error', { allowComputed: true }], | |||
| 'import/no-extraneous-dependencies': 'off', | |||
| 'import/order': ['error', { | |||
There was a problem hiding this comment.
We try to be as unopinionated as possible around the Airbnb rules.
Will that conflict with?
https://github.com/airbnb/javascript/blob/aefff97bd10e8e17963749bd1013a6927d90fe29/packages/eslint-config-airbnb-base/rules/imports.js#L141-L147
There was a problem hiding this comment.
the nested array makes it so all groups can be mingled (other ref)
without the groups option, it defaults to their default group order, which makes a bunch of errors. I used it more for newlines-between to make sure import are together at the top of the file, easier to process
| @@ -31,3 +31,19 @@ export function pageToTitle(page) { | |||
|
|
|||
| return titleize(name); | |||
| } | |||
|
|
|||
| export function getDependencies(raw) { | |||
There was a problem hiding this comment.
Some unit tests for this method would be perfect.
There was a problem hiding this comment.
there are no tests for docs, should I put a helpers.spec.js next to it, (and add a npm script for testing also docs/**?
I think that adding the docs folder for the "test:unit" command is a good tradeoff. The tests won't be run in the CI, nor it will impact codecoverage. One simple test like the repl you linked should be enough :).
|
@caub good job, thanks. |
I think a test will be safer, I've tried a few ones, it seems to work
Follow up for #10150