Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem doesn't respect focusVisibleClassName #11432

Closed
ianschmitz opened this issue May 16, 2018 · 3 comments
Closed

MenuItem doesn't respect focusVisibleClassName #11432

ianschmitz opened this issue May 16, 2018 · 3 comments
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@ianschmitz
Copy link
Contributor

Related to #10976.

The changes in #10976 work awesome for the Switch, however it looks like the MenuItem's focusVisibleClassName prop doesn't work as expected. Passing a focusVisibleClassName to the item works great from a typing perspective, but they don't seem to be applied to the ListItem correctly.

Example: https://codesandbox.io/s/5638ox58n
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels May 16, 2018
@oliviertassinari
Copy link
Member

@ianschmitz Correct, we need to merge the classnames in
https://github.com/mui-org/material-ui/blob/e99f23e85f9f0241a08165b435cd4d51f696ac12/packages/material-ui/src/ListItem/ListItem.js#L108

@oliviertassinari oliviertassinari added the component: list This is the name of the generic UI component, not the React module! label May 16, 2018
rdemirov added a commit to rdemirov/material-ui that referenced this issue May 17, 2018
@rdemirov
fix : mui#11432 Take the focusVisibleClassName property into account
c79a531
@rdemirov rdemirov mentioned this issue May 17, 2018
Merged
@ashwani-pandey
Copy link

Hi @oliviertassinari, can i take up this issue to solve, as i am a beginner and looking forward to contribute to material-ui :)

@oliviertassinari
Copy link
Member

We are happy to hear you want to contribute to Material-UI but @rdemirov is already working on this issue. Don't worry, there is a lot that can be improved.

rdemirov added a commit to rdemirov/material-ui that referenced this issue May 18, 2018
@rdemirov
fix : mui#11432 : Correct classNames call in ListItem.js
2464982
rdemirov added a commit to rdemirov/material-ui that referenced this issue May 18, 2018
@rdemirov
chore: mui#11432 Add property description to the list-item.md file
6c9494e
oliviertassinari pushed a commit to rdemirov/material-ui that referenced this issue May 19, 2018
@rdemirov @oliviertassinari
fix : mui#11432 Take the focusVisibleClassName property into account
c60ff6c
oliviertassinari pushed a commit to rdemirov/material-ui that referenced this issue May 19, 2018
@rdemirov @oliviertassinari
fix : mui#11432 : Correct classNames call in ListItem.js
f2729a8
oliviertassinari pushed a commit to rdemirov/material-ui that referenced this issue May 19, 2018
@rdemirov @oliviertassinari
chore: mui#11432 Add property description to the list-item.md file
32ba3de
oliviertassinari pushed a commit that referenced this issue May 19, 2018
@rdemirov @oliviertassinari
[ListItem] Take the focusVisibleClassName property into account (#11451)
f686308 
* fix : #11432 Take the focusVisibleClassName property into account

* fix : #11432 : Correct classNames call in ListItem.js

* chore: #11432 Add property description to the list-item.md file

* add a test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @ianschmitz @ashwani-pandey