[Dialog, AlertDialog] Fix trigger issues #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: AlertDialog
Netlify deploy preview |
michaldudak
commented
Nov 6, 2024
| @@ -38,17 +38,12 @@ const AlertDialogBackdrop = React.forwardRef(function AlertDialogBackdrop( | |||
| forwardedRef: React.ForwardedRef<HTMLDivElement>, | |||
| ) { | |||
| const { render, className, keepMounted = false, ...other } = props; | |||
| const { open, hasParentDialog, setBackdropPresent, animated } = useAlertDialogRootContext(); | |||
|
|
|||
| const handleMount = React.useCallback(() => setBackdropPresent(true), [setBackdropPresent]); | |||
There was a problem hiding this comment.
I didn't bother refactoring this as we won't need this logic anyway after #623
|
In Safari:
|
|
Safari should work fine now. |
vladmoroz
approved these changes
Nov 7, 2024
atomiks
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the implementation of the Dialog to be more in line with other popup-like components by delegating the trigger logic to Floating UI.
This fixes two issues:
fixes #618
fixes #619