Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NumberField] Correct virtual cursor rendering #1484

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[NumberField] Correct virtual cursor rendering #1484

wants to merge 10 commits into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Feb 28, 2025

Closes #1483
Closes #1237

  1. Handles PointerLock permissions denial (latest Chrome removed the dialog it seems, so not as bad/common now)
  2. Avoids rendering the cursor at all for touch modality

@atomiks atomiks added component: number field This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Feb 28, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit f2c3fc0
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67c1478f90bb8a0008238964
😎 Deploy Preview https://deploy-preview-1484--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: number field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
1 participant
@atomiks