Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collapsible] Update props destructuring to fix Trigger disabled state #1469

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

huijiewei
Copy link
Contributor

Fixed: #1468

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 4e87667
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67bc22ed07a71200080b81e1
😎 Deploy Preview https://deploy-preview-1469--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mj12albert mj12albert changed the title [CollapsibleTrigger] Update props destructuring to use context for disabled state [Collapsible] Update props destructuring to fix Trigger disabled state Feb 24, 2025
@mj12albert mj12albert added bug 🐛 Something doesn't work component: collapsible This is the name of the generic UI component, not the React module! labels Feb 24, 2025
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ~ thanks for working on this and congrats on your first PR here 🎈

@mj12albert mj12albert merged commit 20bf89e into mui:master Feb 24, 2025
22 checks passed
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: collapsible This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Collapsible] disabled prop doesnt work on Root
2 participants