[Popover] modal prop
#1459
Open
[Popover] modal prop
#1459
+139
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
component: menu
This was referenced Feb 18, 2025
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The new prop is missing from the docs |
Fixed – caused by the issue of the root not being identified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modalprop toPopover, likeMenuPopovermatchMenu's "stick" behavior. Prevents multiple popovers from overlapping each other when one is clicked and hovering over if they haveopenOnHoverScroll locking and internal backdrop aren't active if
openReason === 'hover'for either one, even ifmodal=true.Supersedes #1234 and #1231
Closes #623