[Slider] Fix thumb positioning #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
the
component: slider
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
force-pushed
the
fix/slider-thumb-positioning
branch
3 times, most recently
from
3d84498 to
9b9e937
Compare
mj12albert
changed the title
mj12albert
force-pushed
the
fix/slider-thumb-positioning
branch
from
9b9e937 to
1ac42ee
Compare
mj12albert
force-pushed
the
fix/slider-thumb-positioning
branch
from
5ccd245 to
c419c5e
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
michaldudak
reviewed
Feb 5, 2025
| event: React.KeyboardEvent | React.ChangeEvent, | ||
| ) => void; | ||
| /** | ||
| * Callback fired when drag ends and invokes onValueCommitted. |
There was a problem hiding this comment.
nit: it's really up to the consumer to decide when this function is really called (as useSliderRoot doesn't call it itself as far as I can see). IMO a better description would be "Function to be called when drag ends. Invokes onValueCommitted"
michaldudak
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360
Fixes #1406
Demo: https://stackblitz.com/edit/vitejs-vite-zsatgbgk?file=src%2FApp.tsx
The demo shows both fixes:
when setting the value with the NumberField, the corresponding slider should reposition correctly
when dragging a thumb to match the same value set by a NumberField (of an adjacent row) the thumbs should line up exactly and have the same CSS
widthvalueI have followed (at least) the PR section of the contributing guide.