Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix flaky browser tests #1371

Merged
merged 11 commits into from
Feb 20, 2025
Merged

[test] Fix flaky browser tests #1371

merged 11 commits into from
Feb 20, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jan 30, 2025 •
edited
Loading

Skips flaky Menu (likely due to how safe-polygon works) and Avatar tests in browser, adds waitFor for other Avatar flakes that occurred.

@atomiks atomiks added the test label Jan 30, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 80478d6
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67b685db57d48e0008de7eee
😎 Deploy Preview https://deploy-preview-1371--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atomiks atomiks mentioned this pull request Feb 16, 2025
Merged
@atomiks atomiks changed the title [test] Fix MenuRoot flake [test] Fix flaky browser tests Feb 18, 2025
@atomiks atomiks marked this pull request as ready for review February 18, 2025 22:32
mj12albert
mj12albert approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice ~ I started to notice the avatar one yesterday too

@atomiks atomiks merged commit be07bd6 into mui:master Feb 20, 2025
22 checks passed
@atomiks atomiks deleted the fix/menu-flake branch February 20, 2025 04:19
atomiks added a commit to atomiks/base-ui that referenced this pull request Feb 28, 2025
@atomiks
[test] Fix flaky browser tests (mui#1371)
ea87695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomiks @mj12albert