[docs] Custom props order #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladmoroz
requested review from
michaldudak,
atomiks and
colmtuite
as code owners
vladmoroz
commented
Dec 13, 2024
There was a problem hiding this comment.
This file defines the order of things
Netlify deploy preview |
vladmoroz
force-pushed
the
order-of-props
branch
from
549a56b to
026542e
Compare
colmtuite
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having worked in the docs for the past couple weeks, I realised that a custom semi-arbitrary order will feel much less arbitrary than alphabetic.
I'm ordering most related props together, and placing the essential props at the top (like
defaultValue, value, onValueChange)