Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix --grep option when building docs #1089

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mj12albert
Copy link
Member

Fixes #1088

@mj12albert mj12albert added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Dec 13, 2024
@mui-bot
Copy link

mui-bot commented Dec 13, 2024

Netlify deploy preview

https://deploy-preview-1089--base-ui.netlify.app/

Generated by 🚫 dangerJS against 29aab38

@mj12albert mj12albert changed the title docs-infra/fix-grep [docs-infra] Fix --grep option when building docs Dec 13, 2024
@@ -14,8 +14,7 @@
"release:publish": "pnpm publish --recursive --tag latest",
"release:publish:dry-run": "pnpm publish --recursive --tag latest --registry=\"http://localhost:4873/\"",
"release:tag": "node scripts/releaseTag.mjs",
"docs:api": "rimraf --glob ./docs/pages/**/api-docs ./docs/pages/**/api && pnpm docs:api:build",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have these directories any more.
I don't think we need a separate script just for deleting!

@mj12albert mj12albert marked this pull request as ready for review December 13, 2024 13:09
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 13, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 13, 2024
@mj12albert mj12albert merged commit aabaa43 into mui:master Dec 13, 2024
23 checks passed
@mj12albert mj12albert deleted the docs-infra/fix-grep branch December 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs-infra] docs:api script deletes files not matched by --grep
4 participants