Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Arbitrary TXT Records #13

Closed
muhlba91 opened this issue Nov 8, 2023 · 0 comments · Fixed by #3
Closed

Support Arbitrary TXT Records #13

muhlba91 opened this issue Nov 8, 2023 · 0 comments · Fixed by #3
Labels
bug Something isn't working enhancement New feature or request

Comments

@muhlba91
Copy link
Owner

muhlba91 commented Nov 8, 2023 •
edited
Loading

We currently parse the record based on a given regex that would not validate arbitrary TXT records.
TXT records are not allowed to contain spaces, etc.

We want to support arbitrary TXT records and need to adapt verification and parsing: https://github.com/muhlba91/external-dns-provider-adguard/blob/main/internal/adguard/provider.go#L184-L204 / https://github.com/muhlba91/external-dns-provider-adguard/blob/main/internal/adguard/provider.go#L207-L214
muhlba91 added a commit that referenced this issue Nov 9, 2023
@muhlba91
feat: support arbritary TXT records; fix #13
90441b8
@muhlba91 muhlba91 changed the title Support Arbritary TXT Records Support Arbitary TXT Records Nov 9, 2023
@muhlba91 muhlba91 changed the title Support Arbitary TXT Records Support Arbitrary TXT Records Nov 9, 2023
muhlba91 added a commit that referenced this issue Nov 9, 2023
@muhlba91
feat: support arbitrary TXT records; fix #13
bfa4dbc
@github-actions github-actions bot mentioned this issue Nov 9, 2023
Merged
@muhlba91 muhlba91 added bug Something isn't working enhancement New feature or request labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): release 1.0.0 muhlba91/external-dns-provider-adguard
1 participant
@muhlba91