Add stdin as input-parameter to exec-bee #222
Conversation
bees/execbee/execbeefactory.go
Outdated
| @@ -103,6 +104,11 @@ func (factory *ExecBeeFactory) Actions() []bees.ActionDescriptor { | |||
| Description: "command to be executed", | |||
| Type: "string", | |||
| Mandatory: true, | |||
| }, { | |||
There was a problem hiding this comment.
Please make sure to always run gofmt on your sources before committing them. This will avoid formatting errors like this one.
There was a problem hiding this comment.
Sorry, somehow vscode used goreturns after an update
There was a problem hiding this comment.
goreturns should actually be fine, as I believe it also uses gofmt internally. Are you sure it caused that styling?
There was a problem hiding this comment.
It seems there's more to it. I'll try to fix that later
There was a problem hiding this comment.
It seems that gofmt accepts all those syntaxes:
}, {
},
{
},
{
at least on my machine, it only changed the indents, not the newlines. Only if there is more linebreaks than in the last case, those get removed.
There was a problem hiding this comment.
Wow, you are right. Funny that I've noticed that ambiguous behavior before.
bees/execbee/execbee.go
Outdated
| } | ||
|
|
||
| go func() { | ||
| mod.Logf("StdIn" + stdin) |
There was a problem hiding this comment.
The supplied options / parameters are usually already printed out. I guess we could remove it here.
|
Thanks for your contribution! Looking good, just a few remarks I added above. Simply force push to your branch, if you make any changes. |
The commands executed by execbee can now receive data via stdin