Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an option for raw song folder output when building for PS3. #271

Closed
DarkRTA opened this issue Aug 15, 2024 · 3 comments
Closed

Comments

@DarkRTA
Copy link

DarkRTA commented Aug 15, 2024

There are several cases where building a package is not needed (and outright undesirable), so it would be nice if operations supported creating unpacked song folders instead.

This can save a lot of time as building a pkg file is really slow.

@DarkRTA DarkRTA changed the title Consider adding an option for raw song folder outpur when building for PS3. Consider adding an option for raw song folder output when building for PS3. Aug 15, 2024
@mtolly
Copy link
Owner

mtolly commented Aug 18, 2024

Figuring this out now. Assuming the common case is installing directly into RPCS3 drive folders, what would be the most useful place in the folder hierarchy to output songs:

  1. User selects folder rpcs3/dev_hdd0/game, output BLUS30463/USRDIR/<pack folder>/...
  2. User selects folder rpcs3/dev_hdd0/game/BLUS30463/USRDIR, output <pack folder>/...

Option 1 has the advantage that it installs to the right game automatically. But option 2 would let you override this if you know what you're doing, also if you're not installing directly into the RPCS3 drive then maybe it's more expected that the new things in the folder you select would just be the pack folders instead of e.g. BLUS30463. Though maybe that's also more prone to name collision.

I guess it could also pick between the two automatically. So if you select a folder named game then do option 1, a folder named USRDIR do option 2, otherwise one of them (not sure which) would be a default. Does that sound reasonable?

Regardless the default location will be settable in Preferences (and maybe default to RPCS3's usual folder per platform) so you'd generally never have to touch it in the dialog.

@DarkRTA
Copy link
Author

DarkRTA commented Aug 19, 2024

Option 2 looks less surprising in my opinion. Usually when you select an output folder you are expecting the loose files to end up there rather than deeply nested.

That being said if you want the convenience shortcut anyway, this is what I would personally do.

if folder name is `game` (or some other indication that we are doing a direct install to rpcs3):
   do option 1
else:
   do option 2

mtolly added a commit that referenced this issue Sep 28, 2024
- Preference for default folder in select dialog,
  expected this will be RPCS3 .../dev_hdd0/game/BLUS30463/USRDIR
- Supported in one to one, make packs, and make songs

TODO
- Normal compile ps3 folder output (at least RB, other games also?)
- Be smart about subdirectories in the given folder,
  so you can select dev_hdd0, dev_hdd0/game, or dev_hdd0/game/BLUS30463,
  and it will put songs in the right place
- Maybe we can default to the expected RPCS3 folder per OS
@mtolly
Copy link
Owner

mtolly commented Sep 28, 2024

This has been added in version 20240928, to recompile (RB3/RB2/GH3/GHWoR output) and RB Quick Convert. I implemented the idea to autodetect if you are selecting somewhere in the RPCS3 folder chain; I would recommend selecting dev_hdd0 as the output folder. In Preferences you can enter this folder on the PS3 tab so it will be the default for that dialog. Let me know if there are any problems.

@mtolly mtolly closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants