Do not send a body for a GET request

[drairi]

CircleCI doesn't like it

• ❌ Tests added (not needed)
• ✅ All tests pass
• ✅ Branch is up to date and mergeable
• ❌ README and documentation updated (not needed)

Changes

Do not send data with GET requests. CircleCI has begun intermittently to fail, if a data is sent (even if that data is "{}")

Verify

CircleCi::Project.new(org, project).recent_builds

CircleCI has started to return 403 Forbidden if this is sent with data.

You can also see the same effect in these curl requests. The first may fail, the second will not.

curl -X GET --data-binary "{}" "https://circleci.com/api/v1.1/project/github/org/project?circle-token=TOKEN"
curl -X GET "https://circleci.com/api/v1.1/project/github/org/project?circle-token=TOKEN"

---

[lukeredpath]

I've just spent an hour debugging this problem myself - our CI builds started failing on our Danger step where we are using this gem to fetch artefact information from Circle. Seems that Circle has changed their Cloudfront configuration to reject GET requests with a non-empty body.

[drairi]

It seems a bit intermittent, sometimes it works, sometimes it doesn't. I've asked them on twitter if they've changed anything, but no response as yet.

https://twitter.com/sermoa/status/1554817410099806208

My quick-hack solution is to monkeypatch the gem method like this:

module CircleCi
  class Request
    def connection(verb, body = {})
      req = Net::HTTP.const_get(verb.to_s.capitalize, false).new(@uri, DEFAULT_HEADERS)
      req.body = JSON.dump(body) unless verb == :get
      req
    end
  end
end

[drairi]

CircleCI made a change last week to reject jobs with a particular config. Their argument being, "It's never worked so we want to make it obvious that it's not doing what people think it might".

I guess it's a similar thing here. It makes no sense to send a body with a GET request .. but rather than silently ignoring it, they seem to want to fail in an obvious way.

I wish they were a bit more communicative about these breaking changes though, for those of us who have relied on things that were not quite right but still worked.

[zackse]

We are observing the same behavior and can reproduce the issue with curl by supplying a Content-Length header on a GET request:

curl --http1.1 -H "Content-Length: 2" -s \
    https://circleci.com/api/v1.1/project/github/USERNAME/PROJECT/BUILD_NUM?circle-token=TOKEN

Thanks for posting a fix, @drairi!

[devinburnette]

having this problem as well, hope the fix is merged soon!

[drairi]

@mtchavez is this project still active?

[devinburnette]

thanks @mtchavez for getting this merged in. I see there hasn't been a release in almost 3 years so I imagine the changeset is pretty large, but when do you think you'll have time to cut a new release with the latest fix?

[mtchavez]

Version 2.1.0 of the gem is released with the fix

[drairi]

Thank you so much for merging and releasing a new version! Tested and it works beautifully!

In case you're interested, we use thes gem in combination with Smashing Dashboard to show our CircleCI build and test results. All the screens round the office were looking very sad yesterday, and now all the colour is back and everyone is happy again! 😁

[lukeredpath]

Yes, thank you for the quick turnaround on this.

FYI, I had a response to my customer support ticket from CircleCI confirming they did make this change but having identified a "customer impact" they are temporarily reverting the change. It will be rolled out again with an announcement in advance.

[TheMetalCode]

Appreciate the quick turnaround on this!