Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-tests coverage for dup_pattern checker #43

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Conversation

mszostok
Copy link
Owner

Description

Changes proposed in this pull request:

  • Add test coverage for internal pkg

Related issue(s)

Partially solves #14

@mszostok mszostok added the enhancement New feature or request label Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #43 into master will decrease coverage by 64.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #43       +/-   ##
===========================================
- Coverage   82.92%   18.26%   -64.66%     
===========================================
  Files           2       10        +8     
  Lines          41      312      +271     
===========================================
+ Hits           34       57       +23     
- Misses          6      252      +246     
- Partials        1        3        +2     
Impacted Files Coverage Δ
internal/check/duplicated_pattern.go 78.57% <100.00%> (ø)
pkg/codeowners/owners.go 81.08% <100.00%> (ø)
internal/context/check.go 100.00% <0.00%> (ø)
internal/check/not_owned_file.go 0.00% <0.00%> (ø)
internal/check/valid_owner.go 0.00% <0.00%> (ø)
internal/check/api.go 17.24% <0.00%> (ø)
internal/envconfig/envconfig.go 100.00% <0.00%> (ø)
internal/check/valid_owner_error.go 0.00% <0.00%> (ø)
internal/check/file_exists.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c915fc0...2a7e67b. Read the comment docs.

@mszostok mszostok merged commit cbda10c into master Oct 17, 2020
@mszostok mszostok deleted the tests-coverage branch October 17, 2020 02:55
@mszostok mszostok mentioned this pull request Oct 22, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant