update valid owner check to page through teams #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/fix-too-many-teams-for-1-page
branch
from
7ef82ae to
e843b7a
Compare
…n organization than a single result page
jhump
force-pushed
the
jh/fix-too-many-teams-for-1-page
branch
from
e843b7a to
b5fcd4e
Compare
|
@mszostok, any chance you could review this fix? I am in a GitHub organization that has enough teams that we just hit this: we added two new teams but this tool reported our |
|
Hi @jhump sorry for such late response, somehow I didnt notice that 🤦♂ I will check that this weekend and do new release. once again really sorry. I will update readme how you can ping me:
but I will also pay more attention to that repo and change notification. |
|
@mszostok, no worries. I'm patient! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code only downloads 1 page of results when trying to list an organization's teams. By default, a page is only 30 items. So organizations with >30 teams may have some teams that are not visible to the check. This causes the checker to think a config is invalid even if it actually is valid.
This change (1) sets the requested page size to 100 (the max), to reduce GitHub API calls; (2) adds a cache of teams by org to the checker struct, again, to reduce API calls to GitHub; and (3) iterates until the response indicates that there are no more pages.