perl: build for cygwin #5177
Open
perl: build for cygwin #5177
+98
−1,892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is for perl to report that it was built for cygwin ($^O gives "cygwin" for example) and to adjust all the code depending on that and remove all the patches for handing the "msys" case. Everything else should work as before. * In case cygwin check was extended with msys, remove msys case * In case msys check was added, replace with cygwin check * In case msys specific checks/code was added, merge that into the cygwin paths We still check/set the MSYS env var instead of the CYGWIN env var, since msys2-runtime doesn't handle both yet, so keep that as is for now.
|
@dscho since I've always copied the perl work from git4win, any thoughts/feedback on this? It should make updating perl easier in the future. |
jeremyd2019
reviewed
Feb 1, 2025
Comment on lines
+428
to
+435
| -# - eliminate -lc, implied by gcc and a symlink to libcygwin.a | ||
| +# - eliminate -lc, implied by gcc and a symlink to libmsys-2.0.a | ||
| libswanted=`echo " $libswanted " | sed -e 's/ c / /g'` | ||
| -# - eliminate -lm, symlink to libcygwin.a | ||
| +# - eliminate -lm, symlink to libmsys-2.0.a | ||
| libswanted=`echo " $libswanted " | sed -e 's/ m / /g'` | ||
| -# - eliminate -lutil, symbols are all in libcygwin.a | ||
| +# - eliminate -lutil, symbols are all in libmsys-2.0.a |
There was a problem hiding this comment.
Is it really worth patching comments?
There was a problem hiding this comment.
Fair point, but I just copied over the hints/msys.sh changes to hints/cygwin.sh (and adjusting the arch strings) to avoid any other side effects of this PR.
So the diff was there before, just in a different file
I'm fine with removing the comment changes though.
There was a problem hiding this comment.
so cygwin.sh probably diverged since msys.sh was created
There was a problem hiding this comment.
Comment on lines
+448
to
+449
| -test -z "$useithreads" && useithreads='define' | ||
| +test -z "$usethreads" && usethreads='define' |
There was a problem hiding this comment.
see above, not changed in this PR
Comment on lines
+460
to
+468
| - | ||
| -# Seems that exporting _Thread_local doesn't work on cygwin. This 6 year old | ||
| -# gcc bug suggests that maybe the problem really is binutils, but either way | ||
| -# it still doesn't work, despite our probes looking good: | ||
| -# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64697 | ||
| -d_thread_local=undef | ||
| - | ||
| -# Broken: https://sourceware.org/pipermail/cygwin/2022-August/252043.html */ | ||
| -d_newlocale=undef |
There was a problem hiding this comment.
see above, not changed in this PR
| @@ -1364,124 +211,22 @@ index 2bdf799..3637dc0 100644 | |||
| *Term::ReadLine::Stub::devtty = sub { $donotexist }; | |||
| is( Term::ReadLine->devtty(), $donotexist, "devtty mocked" ); | |||
|
|
|||
| + skip('console is CONIN$/CONOUT$ in MSYS2, not /dev/tty', 3) if $^O eq 'msys'; | |||
| + skip('console is CONIN$/CONOUT$ in MSYS2, not /dev/tty', 3) if $^O eq 'cygwin'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is for perl to report that it was built for cygwin ($^O gives "cygwin" for example) and to adjust all the code depending on that and remove all the patches for handing the "msys" case. Everything else should work as before.
We still check/set the MSYS env var instead of the CYGWIN env var, since msys2-runtime doesn't handle both yet, so keep that as is for now.
Part of #3012
edit: confirmed with the test suite that there are no changes in the test results