Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11docker: add 6.7.0 #8044

Closed
wants to merge 1 commit into from
Closed

x11docker: add 6.7.0 #8044

wants to merge 1 commit into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 1, 2021

This PR adds x11docker, a utility for running GUI applications in Docker containers. It allows starting X servers and setting container options for using them automatically. For instance, x11docker --runx --no-auth ghdl/ext gtkwave or x11docker --runx --no-auth aptman/dbhi:bionic-octave octave. It requires Docker Desktop and VcxSrv or Cygwin/X or xpra.

@Biswa96
Copy link
Member

Biswa96 commented Mar 2, 2021

Are not those just some shell scripts? Do we need a package for it?

@1480c1
Copy link
Contributor

1480c1 commented Mar 2, 2021

I'm voting -1 for this one since it requires a package/program that we do not provide, yet. If we could package something like vcxsrv or Cygwin's X11 or one of the other ones in a way that it's available inside the mingw{64,32} repository, then it's a maybe, but since installing this package by itself does not allow it to be useful, I don't think it's worth packaging atm.

@umarcor
Copy link
Contributor Author

umarcor commented Mar 2, 2021

@Biswa96 many Python packages are "just some scripts". The criteria for packaging is the installation complexity and the effort by users for keeping software up to date. These are two different scripts, and one of them depends on the other being available in the PATH. At the same time, versions need to be picked carefully, because runx is not submoduled in x11docker. Therefore, I believe it makes sense to package it.

@1480c1, per reductio ad absurdum, since we don't provide Docker, it doesn't make sense to install any tool for helping with that. I beg to disagree. Docker Desktop is usable on MSYS2 already. It is sensible not to force users to duplicate their setup through either Cygwin or WSL2, unless they want to do so. Yet, adding this package is the first step for justifying the addition of xauth from Xorg. See mviereck/x11docker#325 (comment). Ideally, MSYS2 would provide a useful X server as a package, so that Cygwin or VcxSrv are not required. However, that's rather disruptive because it is non-trivial and MSYS2 per se does not require it, due to MSYS2 tools using native GUI toolkits. This package is useful as-is for users of MSYS2 and Docker which require running GUI tools inside containers.

@1480c1
Copy link
Contributor

1480c1 commented Mar 2, 2021

yet. If we could package something like vcxsrv or Cygwin's X11 or one of the other ones in a way that it's available inside the mingw{64,32} repository, then it's a maybe

Yet, adding this package is the first step for justifying the addition of xauth from Xorg. See mviereck/x11docker#325 (comment). Ideally, MSYS2 would provide a useful X server as a package, so that Cygwin or VcxSrv are not required.

ideally, we would package an x server and other tools required for a proper x11 session before packaging a tool that requires an x server and other tools. This PR as it is is buying a GPU before you have the rest of the system, you are missing a lot of integral components that would make it useful at the moment.

per reductio ad absurdum, since we don't provide Docker, it doesn't make sense to install any tool for helping with that. I beg to disagree. Docker Desktop is usable on MSYS2 already. It is sensible not to force users to duplicate their setup through either Cygwin or WSL2, unless they want to do so

this is sort of irrelevant to my argument as I'm mainly pointing out the x11 part that is missing, docker I understand is almost never packaged on windows than their prebuilt binaries etc. Although in a similar vein with the x server, it may be possible if someone tries to package https://github.com/docker/engine and/or https://github.com/docker/cli

However, that's rather disruptive because it is non-trivial and MSYS2 per se does not require it, due to MSYS2 tools using native GUI toolkits. This package is useful as-is for users of MSYS2 and Docker which require running GUI tools inside containers.

I would say it would be perfectly fine to package something that could potentially help developers in the long run since it isn't like msys2 is hyper-focused on only building native windows packages with the mingw-w64 toolchain all of the time, plus it would make a good pair with ssh

@lazka
Copy link
Member

lazka commented Mar 3, 2021

Hm, my 2c, since this doesn't depend on any mingw packages it should be a msys package. I can't really tell the usefulness re our goal to only allow tools that help us developing mingw packages. But since these are just some scripts I'd be OK with making an exception..

@lazka
Copy link
Member

lazka commented Mar 3, 2021

-> msys2-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants