Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get username from filepath. #265

Merged
merged 1 commit into from
May 17, 2019
Merged

Get username from filepath. #265

merged 1 commit into from
May 17, 2019

Conversation

merisbahti
Copy link
Contributor

No description provided.

@yishilin14
Copy link
Collaborator

Thank you for your PR.

I don't this it is a good idea to extract usernames like this. This is not a common way for people to name their entries. For example, people could have entries like "fun/xxx", "video/xxx", "work/xxx".

@merisbahti
Copy link
Contributor Author

It gets the filename from the last entry in the file-path, so if the path is "fun/facebook.com/myname", the username would be resolved to "myname"

@yishilin14
Copy link
Collaborator

For me, I use either "xxx.com" or "path/xxx.com" as the entry name.

@merisbahti
Copy link
Contributor Author

I still believe getting the filename from the path is better than just sending an empty string, since it's annoying that the password manager clears the username/email field when getting the password.

@yishilin14
Copy link
Collaborator

I read issue #239 and the documentation of browserpass/browserpass-extension. Now I know putting username in the filepath is a convention.

In this PR, pass.xcodeproj/project.pbxproj gets modified (could be related to #247). Could you please commit the original pass.xcodeproj/project.pbxproj? I will squash and merge once it is done.

@merisbahti
Copy link
Contributor Author

Done now!

Awesome, thanks :)

@yishilin14 yishilin14 merged commit c59c727 into mssun:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants