Skip to content

Commit

Permalink
feat: fix empty statistics
Browse files Browse the repository at this point in the history
  • Loading branch information
hartym committed Mar 29, 2024
1 parent 1ada423 commit 224c125
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
14 changes: 11 additions & 3 deletions harp_apps/dashboard/controllers/overview.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from decimal import Decimal
from statistics import mean
from statistics import StatisticsError, mean

from harp.controllers import GetHandler, RouterPrefix, RoutingController
from harp.http import HttpRequest
Expand Down Expand Up @@ -68,7 +68,11 @@ async def get_summary_data(self, request: HttpRequest):
transactions_by_date_list = generate_continuous_time_range(
discontinuous_transactions=transactions_by_date_list, time_bucket=time_bucket, start_datetime=start_datetime
)
mean_apdex = mean(filter(None, [t["meanApdex"] for t in transactions_by_date_list]))
try:
mean_apdex = mean(filter(None, [t["meanApdex"] for t in transactions_by_date_list]))
except StatisticsError:
mean_apdex = None

return json(
{
"apdex": {
Expand Down Expand Up @@ -109,7 +113,11 @@ async def get_overview_data(self, request: HttpRequest):
transactions_by_date_list = generate_continuous_time_range(
discontinuous_transactions=transactions_by_date_list, time_bucket=time_bucket, start_datetime=start_datetime
)
mean_apdex = mean(filter(None, [t["meanApdex"] for t in transactions_by_date_list]))

try:
mean_apdex = mean(filter(None, [t["meanApdex"] for t in transactions_by_date_list]))
except StatisticsError:
mean_apdex = None
return json(
{
"transactions": transactions_by_date_list,
Expand Down
3 changes: 1 addition & 2 deletions harp_apps/dashboard/frontend/src/Pages/System/SystemPage.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Tab } from "ui/Components/Tabs"

import { Page, PageTitle } from "Components/Page"
import { Tab } from "ui/Components/Tabs"

import { SystemDependenciesTabPanel } from "./SystemDependenciesTabPanel.tsx"
import { SystemSettingsTabPanel } from "./SystemSettingsTabPanel.tsx"
Expand Down

0 comments on commit 224c125

Please sign in to comment.