-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISOP expression printing to print.hpp #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I left some small comments that should be addressed before merging.
test/print.cpp
Outdated
@@ -168,4 +168,4 @@ TEST_F( PrintTest, print_kmap ) | |||
} | |||
} | |||
infile.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be reverted, as we expect an empty line at the end of every file.
include/kitty/print.hpp
Outdated
bool brackets = (__builtin_popcount(mask) > 1); | ||
|
||
if (!first_cube) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the formatting for this library we expect spaces after opening and before closing parentheses.
SOP expressions are useful when constructing the GENLIB library for technology mapping
Updated my pull request according to the requested changes:
|
SOP expressions are useful when constructing the GENLIB library for technology mapping. The functions
print_sop_expression
andto_sop_expression
convert the complete truth table and produce the SOP expression, e.g., (b&c)|(a&c)|(a&b) for majority-3.