Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #82 #83

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Issue #82 #83

merged 3 commits into from
Jun 9, 2023

Conversation

grepz
Copy link
Contributor

@grepz grepz commented Mar 12, 2019

Adressing issue #82.

@grepz grepz mentioned this pull request Mar 12, 2019
Closed
kuenishi
kuenishi requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kuenishi kuenishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution, @grepz.

For symmetry, I think having use_nil on the unpacking side would be nicer, too.
Also I'd like you to rebase against the master to get it tested with CI.

@grepz grepz requested a review from kuenishi June 6, 2023 10:15
@kuenishi kuenishi merged commit 14df9be into msgpack:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuenishi kuenishi kuenishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grepz @kuenishi