Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contrib documentation #34

Merged
merged 1 commit into from
Jan 12, 2025
Merged

docs: update contrib documentation #34

merged 1 commit into from
Jan 12, 2025

Conversation

mrsimonemms
Copy link
Owner

@mrsimonemms mrsimonemms commented Jan 12, 2025

Description

Add some contributor documentation, thanks to @MartinLoeper for asking the question

Related Issue(s)

Fixes #

How to test

@mrsimonemms mrsimonemms force-pushed the sje/contrib-docs branch 5 times, most recently from 86a0792 to 3705727 Compare January 12, 2025 15:46
@mrsimonemms
Copy link
Owner Author

Hi @MartinLoeper, can I get your thoughts on these contributor docs please?

@mrsimonemms mrsimonemms marked this pull request as ready for review January 12, 2025 15:47
@MartinLoeper
Copy link
Contributor

This looks good! I did the exact steps for Testing in the DevPod ecosystem with one addition: I created the provider.yaml using the build.sh script and replaced the paths in the binaries section with local paths. That way I was able to install the provider using the devpod cli. That is maybe a bit easier than moving the binary around.

Anyway, my issue was the following: when running devpod up, the machine tried to pull the agent binary from the location specified in the provider.yaml. That means, it would not use the binary you moved right? It seemed like the machine is downloading the agent binary from gh releases instead of pulling it via ssh connection. Is that the case?

@MartinLoeper
Copy link
Contributor

Maybe you should add that the paths might differ when opening the workspace in a devcontainer?
As far as I understand, I have to either use the devpod cli inside the devcontainer or download the new binary from the devcontainer onto the host and exec the given commands on the host.

README.md Outdated Show resolved Hide resolved
@mrsimonemms
Copy link
Owner Author

@MartinLoeper not sure. I did some work last night where I needed to use the GUI/CLI and this process worked for me.

I don't know much about the Agent, except this line in the GUI's Settings -> General:

image

@mrsimonemms mrsimonemms merged commit 854d3a5 into main Jan 12, 2025
3 checks passed
@mrsimonemms mrsimonemms deleted the sje/contrib-docs branch January 12, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants