fix: Fix Preview stretching on Android #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jan 11, 2024
This was referenced Jan 11, 2024
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
* fix: Fix Preview stretching on Android * fix: Simplify Preview size computation * fix: Catch `stopRepeating` error * fix: Fix preview size calculation * Format code * Update CameraSession.kt * Enable CodeScanner in example app * fix: Also update size on surface change * Format * fix: Flip sizes * Revert that stuff again * Update PreviewView.kt * fix: Swap width and height in SurfaceHolder::setFixedSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the Preview View stretching issue on Android by making sure we always re-compute the layout size when either the surface or the view changes.
If you benefit from this change, say thanks by 💖 sponsoring me on GitHub 💖
Changes
Tested on
Related issues