feat: Add support for new External, Continuity and LiDAR Cameras #1813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for four new Camera Devices on iOS:
Blockers
Currently, a device looks like this:
But the external and continuity cameras don't have the device types. They don't tell me whether they're wide-angle or ultra-wide etc., they just say they're external. Therefore I either need to add a
unknown
orexternal
type to the devices, which is kinda lame as the lens information should be known (through FOV/focal length). Only the position should beexternal
in that case.I'll need to investigate this, but unfortunately I don't have a device to test this on. Someone wanna borrow me an iPad?
Changes
Tested on
Related issues