🐛 takePhoto() not always resolving Android

[marcpropeller]

What were you trying to do?

Trying to take a picture using takePhoto. There does seem to be similar bugs reported, but they seem to be talking about emulators and frame processing. I am just trying to take a basic photo. The component is conditionally rendered on a page.

Reproduceable Code

const camera = useRef<Camera>(null);
const [initialising, setInitialising] = useState<boolean>(true);
const [flash, setFlash] = useState<'off' | 'on'>('off');

const takePhoto = useCallback(() => {
	console.log('take photo');
	if (camera.current) {
		if (!initialising) {
			camera?.current
				?.takePhoto({
					flash,
					enableAutoStabilization: true,
				})
				.then(async (file: PhotoFile) => {
					console.log('taken photo');
					console.log(file);
					if (props.onPhotoTaken !== undefined) {
						props.onPhotoTaken(file);
					}
					setSaving(false);
				})
				.catch(e => {
					console.log(e);
				});
		} else {
			Alert.alert(
				'Camera Error',
				'Camera not initialised. Please try again.',
				[
					{
						text: 'Close',
						onPress: () => console.log('Cancel Pressed'),
						style: 'cancel',
					},
				],
				{ cancelable: false }
			);
		}
	} else {
		Alert.alert(
			'Camera Error',
			'Camera reference pending. Please try again.',
			[
				{
					text: 'Close',
					onPress: () => console.log('Cancel Pressed'),
					style: 'cancel',
				},
			],
			{ cancelable: false }
		);
	}
}, [initialising]);

const onError = useCallback((error: CameraRuntimeError) => {
	console.log('Camera error!');
	console.error(error);
}, []);

const onCameraInitialized = useCallback(() => {
	console.log('Camera initialized!');
	setInitialising(false);
}, []);

return (
	<>
		<Camera
			onError={onError}
			style={StyleSheet.absoluteFillObject}
			device={device}
			isActive={isFocused}
			onInitialized={onCameraInitialized}
			photo
			ref={camera}
		/>
		<View style={styles.captureButton}>
			<TouchableOpacity
				onPress={() => {takePhoto();}}
				disabled={initialising}>
				<View style={styles.shadow} />
				<View
					style={[
						styles.captureInnerButton,
						{
							backgroundColor: recording
								? 'red'
								: 'transparent',
						},
					]}
				/>
			</TouchableOpacity>
		</View>
	</>
);

What happened instead?

Seems to ges stuck in some sort of loop with the SurfaceView GC. It doesn't get to the 'taken photo' console.log. On other android phones it seems to work, what's odd is that I've tried this on 3 Xiaomi devices, and it happens on 2 of them (works on Xiaomi Redmi Note 11 Pro (android 12 SKQ1.211006.001, MIUI 13.0.5)). Also tested on a variety of Samsung devices and works.
It will occasionally work, if I take enough photos. Can't seem to find what scenario makes it work as it seems different every time I try. If you need any more information, let me know.

logcat.log

Relevant log output

See attachment above - going over character limit.

Device

Xiaomi Mi 10T (Android 12 SKQ1.211006.001, MIUI 14.0.1), Xiaomi Redmi (Android 10 QKQ1.191215.002, MIUI 12.0.6)

VisionCamera Version

2.15.4

Additional information

• I am using Expo
• I have read the Troubleshooting Guide
• I agree to follow this project's Code of Conduct
• I searched for similar issues in this repository and found none.

[mihailo-misic]

@mrousavy We are also facing an issue that seems very similar.

On some Android phones the takePhoto is called but the promise returned does not resolve.

The problem was reported on the following devices:

• Gigaset GX 290
• Huawei P40 Pro

Since this is a big concern for us, we are ready to sponsor the prioritization of this issue.
How much would it cost and by when could we expect the fix?

[myselfuser1]

Try this https://www.youtube.com/playlist?list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i

[edritech93]

I found this issue on the emulator Android 10

[sinau123]

same here, on Xiaomi Mi A1 android 9.

sometime the error message was [unknown/unknown: [unknown/unknown] Camera is closed.]

[brunezkey]

We're having a similar issue over here.

We're seeing reports of this issue on a daily basis from our application error monitoring system:

[unknown/unknown: [unknown/unknown] Camera is closed.]. This issue is occurring exclusively on Android devices.

We've attempted to reproduce the error using various emulators without success. The affected devices include, but are not limited to:

• Samsung Galaxy S22 Ultra
• Samsung Galaxy S21
• Samsung Galaxy S3
• Samsung Exynos 990
• Moto G Stylus 5G

We're currently investigating the issue and seeking more information to help resolve it. Any extra information you could provide to help us track this issue would be greatly appreciated.

[mrousavy]

Hm, maybe V3 fixes this

[marcpropeller]

Hm, maybe V3 fixes this

Hi @mrousavy,

Thanks for the update. Is the V3 branch in a position that it can be used and are there any breaking changes we need to be aware of? If/when it's good to go, I'll try upgrading and re-test the issue.

Thanks,

[mrousavy]

V3 has a lot of breaking changes regarding Frame Processors as I completely rebuilt and rewrote the feature from the ground up :)

I don't recommend to use it in production yet, but feel free to try

[mrousavy]

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

[chinnuu05]

I'm still getting this issue using webcam0, it is not fixed

[tomtargosz]

I'm seeing this as well.

OS: Android 14
Phone: SAMSUNG Galaxy A13
Library version: 4.2.0

[mczwalker]

Same problem here.

Phone: SAMSUNG GALAXY A21s
Android: 11
Library: 4.5.1,
React Native: 0.74.4

[SwhiteMHC]

I am also experiencing this issue.

Phone: Samsung Galaxy A14 5G
Android: 14
Library: 4.5.1
React Native: 0.74.5

[samuel-andres]

Same here:

Phone: Samsung Galaxy A33 5G (SM-A336B)
Android: 14
Library: 4.5.0
React Native: 0.73.7

and also

Phone: Samsung Galaxy Tab S8 Ultra (SM-X700)
Android: 14
Library: 4.5.0
React Native: 0.73.7

[SwhiteMHC]

I ended up switching to expo-camera for now.

[AlyxsonMarques]

same error here on Samsung A54
Android 14
SM-A546E/DS
React Native 0.73.8