Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow semicolons to be used in commit messages #7

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

creature
Copy link
Contributor

@creature creature commented Sep 2, 2015

If I'm committing two semi-related bits of functionality, I'll often use a semicolon in the commit message to separate them:

git commit -m "Fix escaping of semicolons; unit test to ensure it works."

scmpuff didn't treat the semicolon as a special character. This results in abridged commit messages, and errors in the output:

[master (root-commit) cc10013] Fix escaping of semicolons
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 a.txt
bash:  unit test to ensure it works.: command not found

This PR fixes that. I also tested that actual semicolons are unaffected (eg. git commit -m "Foo; bar"; say "Commit finished"), but I couldn't see a good way to write a test for that case.

@mroth
Copy link
Owner

mroth commented Sep 2, 2015

This looks great @creature. I can't for the life of me figure out why Travis-CI didn't run on the PR, though... 😕

@mroth
Copy link
Owner

mroth commented Sep 6, 2015

Okay, I ran the tests manually locally on this PR, all looks good. Thanks so much for the contribution!

mroth added a commit that referenced this pull request Sep 6, 2015
Allow semicolons to be used in commit messages
@mroth mroth merged commit c25f0e3 into mroth:master Sep 6, 2015
@creature
Copy link
Contributor Author

creature commented Sep 9, 2015

No problem! Glad to have helped. :) I've also got no idea why Travis didn't run on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants