Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git status truncates branch names #12

Closed
milesj opened this issue Feb 5, 2016 · 5 comments
Closed

Git status truncates branch names #12

milesj opened this issue Feb 5, 2016 · 5 comments
Labels

Comments

@milesj
Copy link

milesj commented Feb 5, 2016

Just noticed that gs truncates branch names that are based on versions. For example:

[21:25:11] Miles:toolkit > gs
# On branch: 3  |  No changes (working directory clean)
[21:25:15] Miles:toolkit > git status
On branch 3.0
Your branch is up-to-date with 'origin/3.0'.
nothing to commit, working directory clean
@mroth mroth added the bug label Feb 8, 2016
@mroth
Copy link
Owner

mroth commented Feb 8, 2016

Huh! Something must be messed up with the pattern matching. I'll look into this.

@mroth
Copy link
Owner

mroth commented Feb 8, 2016

@milesj could you please do a git status -z -b in the branch of question and let me know what the output looks like?

@milesj
Copy link
Author

milesj commented Feb 9, 2016

Sure, here you are.

[19:28:23] Miles:toolkit > git status -b -z
## 3.0...origin/3.0 [ahead 1]

mroth added a commit that referenced this issue Feb 9, 2016
@mroth
Copy link
Owner

mroth commented Feb 9, 2016

Okay, reproduced and added a failing test for this in ee03e30.

Will try to take a look at this soon. (If anyone wants to take a stab at it before me, the offending code is almost certainly in https://github.com/mroth/scmpuff/blame/truncated-branch-names/commands/status/process.go#L69-L77 )

mroth added a commit that referenced this issue Feb 26, 2016
@mroth mroth closed this as completed in 04f4efd Feb 26, 2016
@milesj
Copy link
Author

milesj commented Feb 27, 2016

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants