Skip to content

Commit

Permalink
refactor: use go:embed to remove dependency on bindata
Browse files Browse the repository at this point in the history
starting with go1.16, we can now directly embed files using the embed
package.  this will simplify the tool chain here significantly.
  • Loading branch information
mroth committed Dec 5, 2021
1 parent b3407b3 commit 16ec545
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 365 deletions.
10 changes: 3 additions & 7 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
require 'rake/clean'

# special case: we have a bindata file which should be regenerated if source
# file changes. this is needed during development only, so we handle that here
# versus in the build script.
BINDATA = "commands/inits/bindata.go"
file BINDATA => :generate
# aruba's default tmp directory is local
CLEAN.include FileList.new("tmp/*")

# runs the generate script, which will bootstrap anything it needs in script
Expand All @@ -26,13 +22,13 @@ task :install => :build do
end

desc "run unit tests"
task :test => BINDATA do
task :test do
sh "go test ./..."
end

desc "run integration tests"
task :features => :build do
sh "bundle exec cucumber -s --tags=~@wip"
sh "bundle exec cucumber -s --tags='not @wip'"
end

task "features:wip" => :build do
Expand Down
7 changes: 0 additions & 7 deletions commands/inits/.gitignore

This file was deleted.

322 changes: 0 additions & 322 deletions commands/inits/bindata.go

This file was deleted.

3 changes: 0 additions & 3 deletions commands/inits/data/README.md

This file was deleted.

Loading

0 comments on commit 16ec545

Please sign in to comment.