-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update module resolution for non-relative paths #229
Conversation
Hey @mrmckeb! I imagine you've got a ton of other stuff going on, but let me know if you have a chance to take a look at this any time soon! I'd love to get your thoughts. Thanks so much for all of your work on this plugin! |
Any updates? |
Hey @mrmckeb! I just wanted to check in and see whether you might have a chance to take a look at this PR sometime soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smoores-dev - this looks great to me. Sorry for the very slow turnaround, I try to check in once every 2-3 weeks (unless there's a critical issue) but had a bit more going on recently.
Closing and reopening to trigger tests, etc. |
I plan to get this out in the next day or two - I also need to set up automatic releases for this repo. |
Sorry this took so long. Released: |
Fixes #227.
This change generalizes "module resolution with failed lookup locations" so that it works for newer implementations of the typescript language server, which provide such information in the response for
resolveModuleNameLiterals
, rather than implementing a separategetResolvedModuleWithFailedLookupLocationsFromCache
.Tested locally in a project using Typescript 5 and path aliases, and imports like:
which were failing before this change now successfully show type information and support "Go to Definition", etc.