Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2 #43

Closed
wants to merge 2 commits into from
Closed

Support GHC 9.2 #43

wants to merge 2 commits into from

Conversation

sjakobi
Copy link

@sjakobi sjakobi commented Nov 9, 2021

No description provided.

@mrkkrp
Copy link
Owner

mrkkrp commented Nov 11, 2021

Installation of Cabal 3.6 seems to fail.

@sjakobi
Copy link
Author

sjakobi commented Nov 11, 2021

Indeed. Maybe the GHCup version is too old. Purging the cache might help?!

I probably won't debug this further. I can offer reverting the changes to .github/workflows/ci.yaml.

@mrkkrp
Copy link
Owner

mrkkrp commented Nov 11, 2021

I think 3.6 is simply not available in https://github.com/haskell/actions. Doesn't look to be the case:

https://github.com/haskell/actions/blob/main/setup/src/versions.json#L28

@sjakobi
Copy link
Author

sjakobi commented Nov 11, 2021

How about using haskell-ci for generating a GHA config?! haskell-ci does support GHC 9.2.1 and cabal 3.6.

@mrkkrp
Copy link
Owner

mrkkrp commented Nov 11, 2021

There seems to be so many different CI scripts now. Is haskell-ci considered better than haskell/actions? Does it support GitHub actions?

Keep old GHA config only for ormolu
@sjakobi
Copy link
Author

sjakobi commented Nov 11, 2021

Is haskell-ci considered better than haskell/actions? Does it support GitHub actions?

I have simply kept using haskell-ci since the Travis days. I haven't really bothered to learn how to configurate GHA myself.

I think it's pretty easy to use even though documentation is rather sparse. Options can be discovered via haskell-ci --help and should be added to cabal.haskell-ci. If you want to add CI with a different GHC version, add it to the tested-with section and run haskell-ci regenerate. Also, you should install haskell-ci from master. Hackage releases are done rather infrequently.

@sjakobi
Copy link
Author

sjakobi commented Nov 11, 2021

The haskell-ci maintainers are very responsive though. That's a plus for me. :)

Copy link
Author

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bytestring's CI setup is going to have better architecture coverage than GHC! 💪

Apologies, wrong PR! 😊

@sjakobi
Copy link
Author

sjakobi commented Dec 1, 2021

Ping @mrkkrp. :)

@mrkkrp
Copy link
Owner

mrkkrp commented Dec 1, 2021

This is not forgotten. I plan to go over all my packages and update a bunch of things once mtl-2.3 is released. Which should happens tomorrow I guess?

@sjakobi
Copy link
Author

sjakobi commented Dec 2, 2021

Which should happens tomorrow I guess?

Maybe. AFAIK the mtl maintainers need to decide whether the breaking changes included in rc-3 are acceptable first: haskell/mtl#101 (comment)

@mrkkrp
Copy link
Owner

mrkkrp commented Dec 4, 2021

Closing in favor of #45.

@mrkkrp mrkkrp closed this Dec 4, 2021
@sjakobi sjakobi deleted the ghc-9.2 branch December 4, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants