Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phantomjs version to match mocha-phantomjs #34

Merged
merged 1 commit into from
Jul 17, 2015
Merged

Update phantomjs version to match mocha-phantomjs #34

merged 1 commit into from
Jul 17, 2015

Conversation

geowarin
Copy link
Contributor

Hi,

We recently hit a problem where gulp-mocha-phantomjs tries to install the latest version of phantomjs which is now 1.9.17.
The problem is that the current version of mocha-phantomjs has a peer dependency on phantomjs 1.9.1 - 1.9.7-15

One way to fix the problem is to update the phantomjs dependency to exactly match the one declared in mocha-phantomjs 3.3.2.

Another way to fix the problem could be updating to a newer version of mocha-phantomjs.

Could you please have a look at that one really quickly? it is a blocker for us at work.

Many thanks.

Hi,

We recently hit a problem where gulp-mocha-phantomjs tries to install the latest version of phantomjs which is now 1.9.17.
The problem is that the current version of mocha-phantomjs has a peer dependency on phantomjs 1.9.1 - 1.9.7-15

One way to fix the problem is to update the phantomjs dependency to exactly match the one declared in mocha-phantomjs 3.3.2.

Another way to fix the problem could be updating to a newer version of mocha-phantomjs.

Could you please have a look at that one really quickly? it is a blocker for us at work.

Many thanks.
@geowarin
Copy link
Contributor Author

In the meantime, I created a fix package https://www.npmjs.com/package/fix-gulp-mocha-phantomjs
if anyone encounters the problem

@shellscape
Copy link

👍 we just ran into this earlier today, it's crippling our build tools.

@nathanboktae
Copy link
Contributor

Appologies for doing the bump in the patch version rather than minor, but I've rectified that, but gulp-mocha-phantomjs has the ^ depedency rather than ~ so it's still affected.

@geowarin It's bad form to publish a package for just a patch fix. If you or anyone ever needs a fork of a package, you can do:

"gulp-mocha-phantomjs": "git://github.com/geowarin/gulp-mocha-phantomjs#patch-1"

@geowarin
Copy link
Contributor Author

@nathanboktae thanks for the tip!
I will remove the package as soon as the problem is fixed

nathanboktae referenced this pull request in nathanboktae/mocha-phantomjs Jul 16, 2015
@nathanboktae
Copy link
Contributor

Also another way to avoid the breakage is to explicitly reference phantomjs on 1.9.7-15, according to @nickp10

mrhooray pushed a commit that referenced this pull request Jul 17, 2015
Update phantomjs version to match mocha-phantomjs
@mrhooray mrhooray merged commit 803827f into mrhooray:master Jul 17, 2015
@mrhooray
Copy link
Owner

merged and published v0.7.0
sorry for the late response @geowarin

@geowarin
Copy link
Contributor Author

No problem @mrhooray. Sorry if I put pressure on you. I really appreciate your hard work.

I unpublished my package from npm and learned a few things in the process :)

mrhooray pushed a commit that referenced this pull request Nov 19, 2017
Update phantomjs version to match mocha-phantomjs
mrhooray added a commit that referenced this pull request Nov 19, 2017
Update phantomjs version to match mocha-phantomjs
mrhooray added a commit that referenced this pull request Nov 20, 2017
Update phantomjs version to match mocha-phantomjs
mrhooray added a commit that referenced this pull request Nov 20, 2017
Update phantomjs version to match mocha-phantomjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants