-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update phantomjs version to match mocha-phantomjs #34
Conversation
Hi, We recently hit a problem where gulp-mocha-phantomjs tries to install the latest version of phantomjs which is now 1.9.17. The problem is that the current version of mocha-phantomjs has a peer dependency on phantomjs 1.9.1 - 1.9.7-15 One way to fix the problem is to update the phantomjs dependency to exactly match the one declared in mocha-phantomjs 3.3.2. Another way to fix the problem could be updating to a newer version of mocha-phantomjs. Could you please have a look at that one really quickly? it is a blocker for us at work. Many thanks.
In the meantime, I created a fix package https://www.npmjs.com/package/fix-gulp-mocha-phantomjs |
👍 we just ran into this earlier today, it's crippling our build tools. |
Appologies for doing the bump in the patch version rather than minor, but I've rectified that, but gulp-mocha-phantomjs has the @geowarin It's bad form to publish a package for just a patch fix. If you or anyone ever needs a fork of a package, you can do:
|
@nathanboktae thanks for the tip! |
Also another way to avoid the breakage is to explicitly reference |
Update phantomjs version to match mocha-phantomjs
merged and published v0.7.0 |
No problem @mrhooray. Sorry if I put pressure on you. I really appreciate your hard work. I unpublished my package from npm and learned a few things in the process :) |
Update phantomjs version to match mocha-phantomjs
Update phantomjs version to match mocha-phantomjs
Update phantomjs version to match mocha-phantomjs
Update phantomjs version to match mocha-phantomjs
Hi,
We recently hit a problem where gulp-mocha-phantomjs tries to install the latest version of phantomjs which is now 1.9.17.
The problem is that the current version of mocha-phantomjs has a peer dependency on phantomjs 1.9.1 - 1.9.7-15
One way to fix the problem is to update the phantomjs dependency to exactly match the one declared in mocha-phantomjs 3.3.2.
Another way to fix the problem could be updating to a newer version of mocha-phantomjs.
Could you please have a look at that one really quickly? it is a blocker for us at work.
Many thanks.