Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unicorn2 #7

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Support unicorn2 #7

merged 4 commits into from
Dec 23, 2021

Conversation

jtorreno
Copy link
Contributor

@jtorreno jtorreno commented Dec 18, 2021 •
edited by mrexodia
Loading

@mrexodia
Copy link
Owner

Thanks for the contribution! Would there be a way to make it work with both unicorn 1 and 2? I’m not 100% sure if I want to update the package requirement just yet…

@jtorreno
Copy link
Contributor Author

Updated, should work on both versions, can't quite check as I'm on M1. I should as well have probably used importlib.metadata instead of checking __version__ but I don't know how you feel about requiring Python 3.8.

@mrexodia
Copy link
Owner

mrexodia commented Dec 23, 2021 •
edited
Loading

Thanks! Will merge after the CI succeeds.

@mrexodia mrexodia changed the title Target unicorn2 + close #6 Support unicorn2 Dec 23, 2021
@mrexodia mrexodia merged commit e339bd8 into mrexodia:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtorreno @mrexodia