PCSS #9620
Closed
PCSS #9620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int of view) rather than clip space. This is more accurate and gives better results. * Doing random rotation of the fixed poisson disk samples.
…ne size. # Conflicts: # src/lights/SpotLightShadow.js
PCSS Experimentation
Near plane was not getting updated
PCSS Directional Light support
spread Angle for directional lights
This comment has been minimized.
This comment has been minimized.
|
Hmm, there seem to be conflicts in this PR. |
|
@spidersharma03 Nice. Check the typo of the sample's title (Precent Closer Soft-Shadows) |
|
Sorry for breaking this again. Do you mind pulling from |
|
The live example does not load for me. Does this shadow system maintain the lighting from normal maps? The current one does not and is driving me crazy trying to workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCSS with support for spot and directional lights.