-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkinnedMesh support on Editor #8422
Conversation
editor/js/Loader.js
Outdated
|
||
mesh = new THREE.SkinnedMesh( geometry, material ); | ||
|
||
if ( mesh.material.materials !== undefined ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do mesh.material instanceof THREE.MultiMaterial
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine.
@mrdoob |
Ok, so I guess the question is... Where should we store the bones? I don't think we should be storing bones in I recall trying to refactor this at some point by creating the So I guess what's really missing is |
I've been trying some ideas including your reusable (for example, |
I think we should make a different thread for serialization #8978 |
Let's give this another go as soon as |
This PR enables Editor to support SkinnedMesh.
As an example, you can try to import three.js/examples/models/skinned/knight.js
LMK if I should separate PR because this change is across multi files.