fix sRGB encoding, missing constant. #8345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
added a commit
that referenced
this pull request
Mar 12, 2016
fix sRGB encoding, missing constant.
|
Thanks! |
|
Yes, that was apparently my bug - one better remain one. Sorry & thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking each of the encoding functions for correctness while chasing down a bug. Found a bug unrelated to what I was trying to fix.
In the current source
sRGBToLinear( LinearTosRGB( color ) !== color, which is a bug. Adding this constant, which is present in the sRGB Wikipedia article and also arises if you derive LinearTosRGB from sRGBToLinear.The bug is actually present in the example code shared with me here:
#8117 (comment)
The code linked to above should also be corrected to this, notice the addition of the
* 1.055factor:/ping @tschw